Fix for bug 108982: enable taint mode for all user-facing CGI files.

Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave

1 files changed, 7 insertions, 1 deletions

diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi
index a10afb896..4bb90d497 100755
--- a/showdependencygraph.cgi
+++ b/showdependencygraph.cgi
@@ -1,4 +1,4 @@
-#!/usr/bonsaitools/bin/perl -w
+#!/usr/bonsaitools/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public
@@ -23,6 +23,8 @@
 use diagnostics;
 use strict;
 
+use lib qw(.);
+
 require "CGI.pl";
 
 ConnectToDatabase();
@@ -168,6 +170,10 @@ node [URL="${urlbase}show_bug.cgi?id=\\N", style=filled, color=lightgrey]
     # Cleanup any old .dot files created from previous runs.
     my $since = time() - 24 * 60 * 60;
     foreach my $f (glob("data/webdot/*.dot")) {
+        # Here we are deleting all old files. All entries are from the
+        # data/webdot/ directory. Since we're deleting the file (not following
+        # symlinks), this can't escape to delete anything it shouldn't
+        trick_taint($f);
         if (ModTime($f) < $since) {
             unlink $f;
         }