From 87914943d5b70a9623e06f9a615d4e974ffa5764 Mon Sep 17 00:00:00 2001 From: Sam James Date: Mon, 30 Jan 2023 21:53:43 +0000 Subject: BugUrl: add Gerrit (from Eclipse) From https://github.com/eclipsewebmaster/eclipse-bugzilla/commit/161858aa8142316f4057a82d7b691eeaed741b3a. Signed-off-by: Sam James --- Bugzilla/BugUrl.pm | 1 + Bugzilla/BugUrl/Gerrit.pm | 45 +++++++++++++++++++++++++ template/en/default/global/user-error.html.tmpl | 1 + 3 files changed, 47 insertions(+) create mode 100644 Bugzilla/BugUrl/Gerrit.pm diff --git a/Bugzilla/BugUrl.pm b/Bugzilla/BugUrl.pm index b688c9558..674997c61 100644 --- a/Bugzilla/BugUrl.pm +++ b/Bugzilla/BugUrl.pm @@ -68,6 +68,7 @@ use constant SUB_CLASSES => qw( Bugzilla::BugUrl::GitHub Bugzilla::BugUrl::GitLab Bugzilla::BugUrl::Phabricator + Bugzilla::BugUrl::Gerrit ); ############################### diff --git a/Bugzilla/BugUrl/Gerrit.pm b/Bugzilla/BugUrl/Gerrit.pm new file mode 100644 index 000000000..dd231e7c8 --- /dev/null +++ b/Bugzilla/BugUrl/Gerrit.pm @@ -0,0 +1,45 @@ +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +# This Source Code Form is "Incompatible With Secondary Licenses", as +# defined by the Mozilla Public License, v. 2.0. + +package Bugzilla::BugUrl::Gerrit; + +use 5.10.0; +use strict; +use warnings; + +use parent qw(Bugzilla::BugUrl); + + +############################### +#### Methods #### +############################### + +sub should_handle { + my ($class, $uri) = @_; + + # Gerrit Change URL: https://git.eclipse.org/r/#/c/26613/ + # Gerrit Change URL, specific patch set: https://git.eclipse.org/r/#/c/26613/4 + # https://git.eclipse.org/r/40031 + return ( ($uri->path =~ m|^/r/$| and $uri->fragment =~ m|^/c/\d+|) || + $uri->path =~ m|^/r/\d+|) ? 1 : 0; +} + +sub _check_value { + my ($class, $uri) = @_; + + $uri = $class->SUPER::_check_value($uri); + + # While Gerrit URLs can be either HTTP or HTTPS, + # always go with the HTTP scheme, as that's the default. + if ($uri->scheme eq 'http') { + $uri->scheme('https'); + } + + return $uri; +} + +1; diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl index d19d81f97..1c83afadb 100644 --- a/template/en/default/global/user-error.html.tmpl +++ b/template/en/default/global/user-error.html.tmpl @@ -295,6 +295,7 @@
  • An issue/merge request on a GitLab system.
  • A task on a Flyspray tracking system.
  • A revision, support ticket, or task in Phabricator.
  • +
  • A Gerrit change.
  • [% Hook.process('bug_url_invalid_tracker') %] [% END %] -- cgit v1.2.3-65-gdbad