QA fixes; unquoted variables

(Portage version: 2.2_rc45/cvs/Linux x86_64)

2 files changed, 20 insertions, 16 deletions

diff --git a/app-backup/afbackup-server/ChangeLog b/app-backup/afbackup-server/ChangeLog
index 54f0dee4bc3c..8c4924c30ebc 100644
--- a/app-backup/afbackup-server/ChangeLog
+++ b/app-backup/afbackup-server/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for app-backup/afbackup-server
-# Copyright 1999-2007 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/app-backup/afbackup-server/ChangeLog,v 1.3 2007/02/21 20:06:53 peper Exp $
+# Copyright 1999-2009 Gentoo Foundation; Distributed under the GPL v2
+# $Header: /var/cvsroot/gentoo-x86/app-backup/afbackup-server/ChangeLog,v 1.4 2009/10/12 17:14:20 halcy0n Exp $
+
+  12 Oct 2009; Mark Loeser <halcy0n@gentoo.org>
+  afbackup-server-3.3.8.1.ebuild:
+  QA fixes; unquoted variables
 
   21 Feb 2007; Piotr Jaroszyński <peper@gentoo.org> ChangeLog:
   Transition to Manifest2.
diff --git a/app-backup/afbackup-server/afbackup-server-3.3.8.1.ebuild b/app-backup/afbackup-server/afbackup-server-3.3.8.1.ebuild
index 468c2337541c..8657f5677dfc 100644
--- a/app-backup/afbackup-server/afbackup-server-3.3.8.1.ebuild
+++ b/app-backup/afbackup-server/afbackup-server-3.3.8.1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2007 Gentoo Foundation
+# Copyright 1999-2009 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/app-backup/afbackup-server/afbackup-server-3.3.8.1.ebuild,v 1.2 2007/01/24 04:04:02 genone Exp $
+# $Header: /var/cvsroot/gentoo-x86/app-backup/afbackup-server/afbackup-server-3.3.8.1.ebuild,v 1.3 2009/10/12 17:14:20 halcy0n Exp $
 
 inherit eutils
 
@@ -25,11 +25,11 @@ IUSE="zlib"
 DEPEND="zlib? ( sys-libs/zlib )"
 RDEPEND="zlib? ( sys-libs/zlib )"
 
-S=${WORKDIR}/${MY_P}
+S="${WORKDIR}"/${MY_P}
 
 src_unpack() {
 	unpack ${A}
-	cd ${S}
+	cd "${S}"
 
 	sed -i -e 's:subdir="/backup":subdir="/afbackup":' configure
 
@@ -48,7 +48,7 @@ src_unpack() {
 
 	einfo "Using ${AFBACKUPKEY} as your backup key."
 	sed -i -e "s:k=\" \":k=\"${AFBACKUPKEY}\":" ask_for_key
-	echo ${AFBACKUPKEY} > ${S}/afbackup.key
+	echo ${AFBACKUPKEY} > "${S}"/afbackup.key
 }
 
 src_compile() {
@@ -76,26 +76,26 @@ src_install() {
 	einfo "Reconfiguring ${MY_MODE} installation path..."
 	./configure \
 		--host=${CHOST} \
-		--prefix=${D}/opt \
-		--with-serverconfdir=${D}/etc/afbackup \
+		--prefix="${D}"/opt \
+		--with-serverconfdir="${D}"/etc/afbackup \
 		--with-serverconf=server.conf \
-		--with-servermandir=${D}/usr/share/man \
-		--with-clientconfdir=${D}/etc/afbackup \
+		--with-servermandir="${D}"/usr/share/man \
+		--with-clientconfdir="${D}"/etc/afbackup \
 		--with-clientconf=client.conf \
-		--with-clientmandir=${D}/usr/share/man \
-		--mandir=${D}/usr/share/man \
+		--with-clientmandir="${D}"/usr/share/man \
+		--mandir="${D}"/usr/share/man \
 		${myconf} || die "./configure failed"
 
 	einfo "Installing: afbackup-${MY_MODE}"
-	make DESTDIR=${D} install.${MY_MODE} || die
+	make DESTDIR="${D}" install.${MY_MODE} || die
 
 	# fix path in config files
 	einfo "Fixing paths in ${MY_MODE}.conf"
 	if [ "x${MY_MODE}" = "xserver" ]; then
-	sed -i -e "s:${D}::g" ${D}/etc/afbackup/server.conf
+	sed -i -e "s:${D}::g" "${D}"/etc/afbackup/server.conf
 	fi
 	if [ "x${MY_MODE}" = "xclient" ]; then
-	sed -i -e "s:${D}::g" ${D}/etc/afbackup/client.conf
+	sed -i -e "s:${D}::g" "${D}"/etc/afbackup/client.conf
 	fi
 
 	# if new, install key and set permissions