QA: Improved description a bit, quoted $D, removed $ROOT from src_compile

(Portage version: 2.2_rc17/cvs/Linux 2.6.28-rc8 x86_64)

4 files changed, 24 insertions, 20 deletions

diff --git a/media-libs/coin/ChangeLog b/media-libs/coin/ChangeLog
index 75285f71272d..8593e31fd066 100644
--- a/media-libs/coin/ChangeLog
+++ b/media-libs/coin/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for media-libs/coin
-# Copyright 2002-2007 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/ChangeLog,v 1.23 2007/10/21 13:39:55 carlo Exp $
+# Copyright 2002-2008 Gentoo Foundation; Distributed under the GPL v2
+# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/ChangeLog,v 1.24 2008/12/15 19:39:51 angelos Exp $
+
+  15 Dec 2008; Christoph Mende <angelos@gentoo.org> coin-2.4.5.ebuild,
+  coin-2.4.6.ebuild, coin-2.5.0.ebuild:
+  QA: Improved description a bit, quoted $D, removed $ROOT from src_compile
 
 *coin-2.5.0 (21 Oct 2007)
 
diff --git a/media-libs/coin/coin-2.4.5.ebuild b/media-libs/coin/coin-2.4.5.ebuild
index a42cc4d09abf..0076cc138907 100644
--- a/media-libs/coin/coin-2.4.5.ebuild
+++ b/media-libs/coin/coin-2.4.5.ebuild
@@ -1,13 +1,13 @@
-# Copyright 1999-2007 Gentoo Foundation
+# Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/coin-2.4.5.ebuild,v 1.4 2007/07/22 09:41:34 dberkholz Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/coin-2.4.5.ebuild,v 1.5 2008/12/15 19:39:51 angelos Exp $
 
 inherit eutils
 
 MY_P=${P/c/C}
-S=${WORKDIR}/${MY_P}
+S="${WORKDIR}/${MY_P}"
 
-DESCRIPTION="Coin3D is a high-level 3D graphics toolkit, fully compatible with SGI Open Inventor 2.1."
+DESCRIPTION="a high-level 3D graphics toolkit, fully compatible with SGI Open Inventor 2.1."
 HOMEPAGE="http://www.coin3d.org/"
 SRC_URI="ftp://ftp.coin3d.org/pub/coin/src/all/${MY_P}.tar.gz"
 
@@ -59,14 +59,14 @@ src_compile() {
 			# $(use_enable javascript javascript-api) \
 			# $(use_with javascript spidermonkey) \
 
-	econf ${myconf} htmldir=${ROOT}usr/share/doc/${PF}/html || die "econf failed"
+	econf ${myconf} htmldir=/usr/share/doc/${PF}/html
 	emake || die "emake failed"
 }
 
 src_install() {
-	emake DESTDIR=${D} install || die "emake install failed"
+	emake DESTDIR="${D}" install || die "emake install failed"
 	dodoc AUTHORS NEWS README* RELNOTES THANKS
 
 	# Waiting for a maintainer to fix, see #117756.
-	rm -f ${D}/usr/share/man/man3/_var_tmp* ${D}/usr/sharedoc/coin-2.4.4/html/dir__*
+	rm -f "${D}"/usr/share/man/man3/_var_tmp* "${D}"/usr/sharedoc/coin-2.4.4/html/dir__*
 }
diff --git a/media-libs/coin/coin-2.4.6.ebuild b/media-libs/coin/coin-2.4.6.ebuild
index f352ab361713..47a8c7a22471 100644
--- a/media-libs/coin/coin-2.4.6.ebuild
+++ b/media-libs/coin/coin-2.4.6.ebuild
@@ -1,13 +1,13 @@
-# Copyright 1999-2007 Gentoo Foundation
+# Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/coin-2.4.6.ebuild,v 1.1 2007/10/21 13:18:03 carlo Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/coin-2.4.6.ebuild,v 1.2 2008/12/15 19:39:51 angelos Exp $
 
 inherit eutils
 
-MY_P="${P/c/C}"
+MY_P=${P/c/C}
 S="${WORKDIR}/${MY_P}"
 
-DESCRIPTION="Coin3D is a high-level 3D graphics toolkit, fully compatible with SGI Open Inventor 2.1."
+DESCRIPTION="a high-level 3D graphics toolkit, fully compatible with SGI Open Inventor 2.1."
 HOMEPAGE="http://www.coin3d.org/"
 SRC_URI="ftp://ftp.coin3d.org/pub/coin/src/all/${MY_P}.tar.gz"
 
@@ -59,7 +59,7 @@ src_compile() {
 			# $(use_enable javascript javascript-api) \
 			# $(use_with javascript spidermonkey) \
 
-	econf ${myconf} htmldir="${ROOT}usr/share/doc/${PF}/html" || die "econf failed"
+	econf ${myconf} htmldir=/usr/share/doc/${PF}/html
 	emake || die "emake failed"
 }
 
diff --git a/media-libs/coin/coin-2.5.0.ebuild b/media-libs/coin/coin-2.5.0.ebuild
index 547e1252f533..215a85007aa0 100644
--- a/media-libs/coin/coin-2.5.0.ebuild
+++ b/media-libs/coin/coin-2.5.0.ebuild
@@ -1,13 +1,13 @@
-# Copyright 1999-2007 Gentoo Foundation
+# Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/coin-2.5.0.ebuild,v 1.1 2007/10/21 13:39:55 carlo Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-libs/coin/coin-2.5.0.ebuild,v 1.2 2008/12/15 19:39:51 angelos Exp $
 
 inherit eutils
 
-MY_P="${P/c/C}"
+MY_P=${P/c/C}
 S="${WORKDIR}/${MY_P}"
 
-DESCRIPTION="Coin3D is a high-level 3D graphics toolkit, fully compatible with SGI Open Inventor 2.1."
+DESCRIPTION="a high-level 3D graphics toolkit, fully compatible with SGI Open Inventor 2.1."
 HOMEPAGE="http://www.coin3d.org/"
 SRC_URI="ftp://ftp.coin3d.org/pub/coin/src/all/${MY_P}.tar.gz"
 
@@ -42,8 +42,8 @@ src_compile() {
 			--without-simage \
 			--with-doxygen \
 			--with-freetype \
-			--enable-symbols \
 			$(use_enable debug) \
+			$(use_enable debug symbols) \
 			$(use_enable doc html) \
 			$(use_with bzip2) \
 			$(use_with fontconfig) \
@@ -59,7 +59,7 @@ src_compile() {
 			# $(use_enable javascript javascript-api) \
 			# $(use_with javascript spidermonkey) \
 
-	econf ${myconf} htmldir="${ROOT}usr/share/doc/${PF}/html" || die "econf failed"
+	econf ${myconf} htmldir=/usr/share/doc/${PF}/html
 	emake || die "emake failed"
 }