aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcin Kościelnicki <koriakin@0x04.net>2016-03-06 16:38:52 +0100
committerMarcin Kościelnicki <koriakin@0x04.net>2016-03-09 18:43:54 +0100
commitcc2c4da8813b980a4e68272bb43583f4af6fe89c (patch)
treed9bca39562fdf1e4c32fded351f4c73c57a1b92a /gdb/corefile.c
parentgdb: Add gen_return_address for powerpc. (diff)
downloadbinutils-gdb-cc2c4da8813b980a4e68272bb43583f4af6fe89c.tar.gz
binutils-gdb-cc2c4da8813b980a4e68272bb43583f4af6fe89c.tar.bz2
binutils-gdb-cc2c4da8813b980a4e68272bb43583f4af6fe89c.zip
gdb/rs6000: Read backchain as unsigned.
Previously, backchain was read as a signed quantity, resulting in addresses like 0xfffffffffffeded0 instead of 0xfffeded0 returned by unwinder on 32-bit powerpc. While normally such addresses are masked off, this causes problems for tracepoints, since 0xfffffffffffeded0 is considered unavailable. Fixes a test failure in gdb.trace/entry-values.exp. gdb/ChangeLog: * corefile.c (safe_read_memory_unsigned_integer): New function. * gdbcore.h (safe_read_memory_unsigned_integer): New prototype. * rs6000-tdep.c (rs6000_frame_cache): Read backchain as unsigned.
Diffstat (limited to 'gdb/corefile.c')
-rw-r--r--gdb/corefile.c18
1 files changed, 18 insertions, 0 deletions
diff --git a/gdb/corefile.c b/gdb/corefile.c
index dbdbafc41f1..5ad4d40ec66 100644
--- a/gdb/corefile.c
+++ b/gdb/corefile.c
@@ -306,6 +306,24 @@ safe_read_memory_integer (CORE_ADDR memaddr, int len,
return 1;
}
+/* Read memory at MEMADDR of length LEN and put the contents in
+ RETURN_VALUE. Return 0 if MEMADDR couldn't be read and non-zero
+ if successful. */
+
+int
+safe_read_memory_unsigned_integer (CORE_ADDR memaddr, int len,
+ enum bfd_endian byte_order,
+ ULONGEST *return_value)
+{
+ gdb_byte buf[sizeof (ULONGEST)];
+
+ if (target_read_memory (memaddr, buf, len))
+ return 0;
+
+ *return_value = extract_unsigned_integer (buf, len, byte_order);
+ return 1;
+}
+
LONGEST
read_memory_integer (CORE_ADDR memaddr, int len,
enum bfd_endian byte_order)