aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormkanat%bugzilla.org <>2006-07-06 13:12:04 +0000
committermkanat%bugzilla.org <>2006-07-06 13:12:04 +0000
commitf162521444148d622df3b42a8304b6cce8f2150e (patch)
tree78cf6a0bfad99a4f053c998b98efe36929475005 /chart.cgi
parentBug 343702: editflagtypes.cgi: Argument "" isn't numeric in numeric gt (>) at... (diff)
downloadbugzilla-f162521444148d622df3b42a8304b6cce8f2150e.tar.gz
bugzilla-f162521444148d622df3b42a8304b6cce8f2150e.tar.bz2
bugzilla-f162521444148d622df3b42a8304b6cce8f2150e.zip
Bug 173629: Clean up "my" variable scoping issues for mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk
Diffstat (limited to 'chart.cgi')
-rwxr-xr-xchart.cgi10
1 files changed, 7 insertions, 3 deletions
diff --git a/chart.cgi b/chart.cgi
index fd7025855..680eeb7b5 100755
--- a/chart.cgi
+++ b/chart.cgi
@@ -53,9 +53,13 @@ use Bugzilla::Chart;
use Bugzilla::Series;
use Bugzilla::User;
-my $cgi = Bugzilla->cgi;
-my $template = Bugzilla->template;
-my $vars = {};
+# For most scripts we don't make $cgi and $template global variables. But
+# when preparing Bugzilla for mod_perl, this script used these
+# variables in so many subroutines that it was easier to just
+# make them globals.
+local our $cgi = Bugzilla->cgi;
+local our $template = Bugzilla->template;
+local our $vars = {};
# Go back to query.cgi if we are adding a boolean chart parameter.
if (grep(/^cmd-/, $cgi->param())) {