aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam James <sam@gentoo.org>2023-01-18 18:28:40 +0000
committerSam James <sam@gentoo.org>2023-01-18 18:28:40 +0000
commit1d65e1921d23cc9471ed4d909429f98bed0bfcf2 (patch)
tree7b069944e1da73632ccffd02250326f27858b1b1
parenteapi-usage.sh: optimise + refactor (diff)
downloadqa-scripts-1d65e1921d23cc9471ed4d909429f98bed0bfcf2.tar.gz
qa-scripts-1d65e1921d23cc9471ed4d909429f98bed0bfcf2.tar.bz2
qa-scripts-1d65e1921d23cc9471ed4d909429f98bed0bfcf2.zip
eapi-usage.sh: update commentary re pinspect usage
We previously stopped using it because pkgcore at the time lacked support for newer EAPIs (>= EAPI 5), but now it's less appealing to switch back despite the elegance (and nicer output, I suppose) given the awk works and is a fair bit faster. Signed-off-by: Sam James <sam@gentoo.org>
-rwxr-xr-xeapi-usage.sh8
1 files changed, 5 insertions, 3 deletions
diff --git a/eapi-usage.sh b/eapi-usage.sh
index 62e878f..b7a1112 100755
--- a/eapi-usage.sh
+++ b/eapi-usage.sh
@@ -56,12 +56,14 @@ mv ${TMPDIR}/eapi-usage/*.txt ${dir}/ || exit 1
rm -r "${TMPDIR}" || exit 1
# Now generate the numbers/summary (copied in from previous eapi_usage.sh script)
-# Boring 'script' that just uses pkgcore's pinspect command. Someday it would be
-# nice to graph this output, or maybe keep some running history?
-
+# Someday it would be nice to graph this output, or maybe keep some running history?
+# TODO: We used pinspect in the past which is cleaner but it's slower than the
+# awk method used below (we also stopped using it because at the time, pkgcore
+# lacked newer EAPI support).
#[[ $(type pinspect 2> /dev/null) ]] || exit 1
#
#pinspect eapi_usage /usr/portage
+
find "${REPO_PATH}"/metadata/md5-cache -type f ! -name '*.gz' \
-exec grep -h '^EAPI=' '{}' + \
| awk '